Store in Weekly Directory

Post any problems / bugs / issues that are Mylar-related in here.
Post Reply
Oizo
Posts: 72
Joined: Sat Nov 15, 2014 11:53 am

Store in Weekly Directory

Post by Oizo »

Is it supposed to download every week automatically if the box is ticked? If yes then it doesn't work. If I click on the download button it works - but only for the current week.
If I go back a week or to clicking download will create the folder, but won't copy the downloaded files into this folder.

Code: Select all

2016-11-24 20:39:42	INFO	I have copied 0 issues from this Week's pullist as requested.
2016-11-24 20:39:42	INFO	Directory successfully created at: /volume1/Comics/ComicsNew/2016-44
2016-11-24 20:39:42	INFO	Directory doesn't exist!
2016-11-24 20:39:42	INFO	pulldate: {'weeknumber': 44, 'endweek': 'November 05, 2016', 'year': 2016, 'next_weeknumber': 45, 'prev_weeknumber': 43, 'midweek': '2016-11-02', 'current_weeknumber': '47', 'startweek': 'October 30, 2016'}
User avatar
evilhero
Site Admin
Posts: 2883
Joined: Sat Apr 20, 2013 3:43 pm
Contact:

Re: Store in Weekly Directory

Post by evilhero »

The copy process only works when you do a post-processing run that has those issues from the given week in them. With the option enabled, when Mylar is performing post-processing on the issues, it will put them into the required series location folders and then copy them into the weekly folder as indicated in the weekly pull page. I do have to update the logic so that it is either copy/hardlink/symlink, but that's another issue.

The Download option will check your series that are on the pullist for issues that are in a Downloaded status and copy those issues from the series directories into the given weekly pull folder.

Going back a week doesn't work (or it shouldn't - I'm pretty sure the code would break since the dates/issues wouldn't be located given the current codebase). I'll have to update the code in order to support going back multiple weeks to allow the Download option to work (and thereby post-processing as well).
Oizo
Posts: 72
Joined: Sat Nov 15, 2014 11:53 am

Re: Store in Weekly Directory

Post by Oizo »

I've seen you fixed this in the latest update - awesome!
Oizo
Posts: 72
Joined: Sat Nov 15, 2014 11:53 am

Re: Store in Weekly Directory

Post by Oizo »

One of the latest updates seems to have broken it completely - at least for me:

Code: Select all

500 Internal Server Error

The server encountered an unexpected condition which prevented it from fulfilling the request.

Traceback (most recent call last):
  File "/usr/local/mylar/share/mylar/lib/cherrypy/_cprequest.py", line 645, in respond
    response.body = self.handler()
  File "/usr/local/mylar/share/mylar/lib/cherrypy/lib/encoding.py", line 188, in __call__
    self.body = self.oldhandler(*args, **kwargs)
  File "/usr/local/mylar/share/mylar/lib/cherrypy/_cpdispatch.py", line 29, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/volume1/@appstore/mylar/share/mylar/mylar/webserve.py", line 3305, in MassWeeklyDownload
    pulldate = ast.literal_eval(pulldate)
  File "/usr/local/python/lib/python2.7/ast.py", line 80, in literal_eval
    return _convert(node_or_string)
  File "/usr/local/python/lib/python2.7/ast.py", line 63, in _convert
    in zip(node.keys, node.values))
  File "/usr/local/python/lib/python2.7/ast.py", line 62, in <genexpr>
    return dict((_convert(k), _convert(v)) for k, v
  File "/usr/local/python/lib/python2.7/ast.py", line 79, in _convert
    raise ValueError('malformed string')
ValueError: malformed string
I already restarted several times, did not fix it
User avatar
evilhero
Site Admin
Posts: 2883
Joined: Sat Apr 20, 2013 3:43 pm
Contact:

Re: Store in Weekly Directory

Post by evilhero »

What are you using for your alt_pull method (in the config.ini)?

And which commit are you currently running of the dev branch?
Oizo
Posts: 72
Joined: Sat Nov 15, 2014 11:53 am

Re: Store in Weekly Directory

Post by Oizo »

I'm using alt_pull = 2 and Version: 7155f1f83161391ff1956ea2099117ea3a0da3f2 (development) - should be the latest one
User avatar
evilhero
Site Admin
Posts: 2883
Joined: Sat Apr 20, 2013 3:43 pm
Contact:

Re: Store in Weekly Directory

Post by evilhero »

Yep, that was the latest commit - up until an hour ago ;)

A few fixes just went into dev, especially ea53e30409675b58a6c2ce95ea2047686a63f3e2 which should fix your issue with the pullist (there was some refactoring done for another issue and it affected the pullist download button, yet again).
Oizo
Posts: 72
Joined: Sat Nov 15, 2014 11:53 am

Re: Store in Weekly Directory

Post by Oizo »

Works perfectly!
You are aewsome!
Post Reply