Volume = noversion

Enhancement requests or feature requests for future Mylar releases.
Post Reply
elGALLO
Posts: 8
Joined: Tue Apr 07, 2015 4:23 am

Volume = noversion

Post by elGALLO »

Currently my setup is $Publisher/$Series/$Series $Annual v$VolumeN $Issue ($Year)

Annual works as expected (if not annual no annual tag) however if there is no volume # listed on comic vine Mylar will name the folder

/path/to/Marvel/Punisher/Punisher vnoversion 010 (2010)

(Not an actual comic just an example)

Would there be a way to have Mylar no print anything if it returns "noversion". Ideally .../Punisher 010 (2010)
But considering that I have to type 'v' it probably couldn't scrub the preceding 'v'.
User avatar
evilhero
Site Admin
Posts: 2883
Joined: Sat Apr 20, 2013 3:43 pm
Contact:

Re: Volume = noversion

Post by evilhero »

elGALLO wrote:Currently my setup is $Publisher/$Series/$Series $Annual v$VolumeN $Issue ($Year)

Annual works as expected (if not annual no annual tag) however if there is no volume # listed on comic vine Mylar will name the folder

/path/to/Marvel/Punisher/Punisher vnoversion 010 (2010)

(Not an actual comic just an example)

Would there be a way to have Mylar no print anything if it returns "noversion". Ideally .../Punisher 010 (2010)
But considering that I have to type 'v' it probably couldn't scrub the preceding 'v'.
I guess it depends on how you're doing the renaming - if it's via the Rename Files button at the top of the Series Detail page, or through post-processing.

Regardless of the how, you don't have to precede your format string with the 'v' in front of $VolumeN.

Mylar automatically puts the 'v' in front if a volume number exists. If it doesn't exist, it just removes the entire thing (just like for annuals). I tested this on the current development build, with a series with a volume label, and without - and it worked on both accounts (wrote 'v9', and 'didn't write a volume label at all).

It might be related to the series you're trying to do the renaming on (what you have in the Version Number field in Mylar will dictate how it renames the files in these instances (if it doesn't have a volume, it should read 'None')

I haven't tested this against a post-processing run, but it's identical logic, so it should perform the same.
elGALLO
Posts: 8
Joined: Tue Apr 07, 2015 4:23 am

Re: Volume = noversion

Post by elGALLO »

Thanks for the response. I had tried something early on in my setup with $VolumeN (a series with multiple volumes TASM or Wolverine or the like) and it was renaming the file as
The Amazing Spider-Man 1 001 (1963)
(not this specifically just an example) and I came up with the idea of v$VolumeN. Perhaps the 'v' throws off the parsing logic and where 'noversion' would not be written, because I precede it with 'v' I now force "noversion" to be written.

Anywho thanks again
Zethoun
Posts: 3
Joined: Fri May 06, 2016 7:13 am

Re: Volume = noversion

Post by Zethoun »

Hello,

I have a similar problem, but only for folder naming.

if I use $VolumeN in my issue format, everything run as it should ( Serie vX or Serie, depend if there is a volume number or not)

but for the folder format, there is 2 "bugs"

settings:
Folder Format: $Publisher/$Series $VolumeN ($Year)
file Format: $Series $VolumeN $Issue

1- there is no "v" in front of the volume number
-- adding She-Hulk volume 2 create the folder named "She-Hulk 2 (2005)" and rename the file "She-Hulk v2 001.cbz"
As you can see, the folder lack the "v" for the volume

2- the infamous "noversion" for the folder naming
-- adding She-Hulks (no volume for this 4 issue limited-series) create the folder named "She-Hulks noversion (2011)" and rename the file "She-Hulks 001.cbz"

I'm using the Automatic Folder Creation of the search/add this Comic feature for the folder creation and the Rename Files of the comicDetails webpage

- Configuration:
Mylar Version: master
-- git build 8082a61f17100f022a3daa754c9f7a764ecf7a38.
Python Version : 2.7.11

- OS: Synology DSM 6.0-7321 Update 5

in case its help:

DEBUG LOG for SHe-Hulk volume 2 creation:

Code: Select all

2016-05-10 20:09:26	DEBUG	{'ComicIssues': u'38', 'ComicName': u'She-Hulk', 'ComicVersion': u'2', 'FirstIssueID': u'107056', 'ComicPublisher': u'Marvel', 'ComicYear': u'2005', 'ComicImageALT': u'http://static4.comicvine.com/uploads/scale_small/1/11307/448626-she_hulk_01_00.jpg', 'ComicURL': u'http://comicvine.gamespot.com/she-hulk/4050-18293/', 'ComicImage': u'http://static5.comicvine.com/uploads/scale_large/1/11307/448626-she_hulk_01_00.jpg', 'Aliases': 'None'}
2016-05-10 20:09:26	DEBUG	Volume information found! Adding to series record : volume 2
2016-05-10 20:09:26	DEBUG	volume X format - 0: Volume 2This ne
2016-05-10 20:09:25	DEBUG	vari is set to: no
2016-05-10 20:09:25	DEBUG	number of issues CV says it has: 38
2016-05-10 20:09:25	DEBUG	number of issues I counted: 38
DEBUG LOG for She-Hulks creation:

Code: Select all

2016-05-10 20:07:39	DEBUG	{'ComicIssues': u'4', 'ComicName': u'She-Hulks', 'ComicVersion': 'noversion', 'FirstIssueID': u'242167', 'ComicPublisher': u'Marvel', 'ComicYear': u'2011', 'ComicImageALT': u'http://static4.comicvine.com/uploads/scale_small/0/6535/1502039-shehulks1.jpg', 'ComicURL': u'http://comicvine.gamespot.com/she-hulks/4050-36561/', 'ComicImage': u'http://static5.comicvine.com/uploads/scale_large/0/6535/1502039-shehulks1.jpg', 'Aliases': 'None'}
2016-05-10 20:07:39	DEBUG	comic[ComicVersion]:noversion
2016-05-10 20:07:39	DEBUG	vari is set to: no
2016-05-10 20:07:39	DEBUG	number of issues CV says it has: 4
2016-05-10 20:07:39	DEBUG	number of issues I counted: 4
User avatar
evilhero
Site Admin
Posts: 2883
Joined: Sat Apr 20, 2013 3:43 pm
Contact:

Re: Volume = noversion

Post by evilhero »

This has already been fixed in the development branch, which should be merged into the master branch soon.
Post Reply